Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC Recover #3696

Merged
merged 22 commits into from
Feb 17, 2025
Merged

EC Recover #3696

merged 22 commits into from
Feb 17, 2025

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 24, 2025

Description

Close #3628
Alternative to #3633

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Crypto tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon mentioned this pull request Jan 24, 2025
15 tasks
@shargon shargon marked this pull request as ready for review January 24, 2025 09:12
@shargon
Copy link
Member Author

shargon commented Jan 24, 2025

@neo-project/core Please take special look into HashAlgorithm.None I think that is well implemented and it can't produce a state difference in other places

@shargon shargon requested a review from Jim8y January 26, 2025 10:11
@shargon shargon added the Help Wanted We suggest a careful read at https://docs.neo.org/. However, fell free to further discuss the topic. label Feb 11, 2025
@shargon shargon requested a review from Jim8y February 11, 2025 11:50
@Jim8y Jim8y self-assigned this Feb 13, 2025
@Jim8y Jim8y removed the Help Wanted We suggest a careful read at https://docs.neo.org/. However, fell free to further discuss the topic. label Feb 14, 2025
@Jim8y Jim8y requested a review from nan01ab February 14, 2025 12:09
@shargon
Copy link
Member Author

shargon commented Feb 14, 2025

@Jim8y thanks for fix it!

@Jim8y
Copy link
Contributor

Jim8y commented Feb 14, 2025

@Jim8y thanks for fix it!

my pleasure

Jim8y
Jim8y previously approved these changes Feb 14, 2025
Jim8y
Jim8y previously approved these changes Feb 15, 2025
cschuchardt88
cschuchardt88 previously approved these changes Feb 15, 2025
nan01ab
nan01ab previously approved these changes Feb 15, 2025
@shargon shargon dismissed stale reviews from cschuchardt88, nan01ab, and Jim8y via aedbc82 February 15, 2025 14:35
@NGDAdmin NGDAdmin merged commit f8f2cdb into master Feb 17, 2025
7 checks passed
@NGDAdmin NGDAdmin deleted the ec-recover-v2 branch February 17, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recover Public Key from Signature for Secp256k1
8 participants